Talk:Standard Edit Summary

When I started using this script, I made some changes, including merging the duplicate code, ignoring comments, and fixing tabindexes.

I don't know what the protocol is for editing code that is possibly in use, so I've posted the changes here for others: Standard_Edit_Summary/Changes -452 17:26, December 18, 2012 (UTC)


 * You might also want to see this.— UltimateSupreme (Talk) 18:34, December 18, 2012 (UTC)


 * The select is inaccessible when the source editor is in wide mode. This should fix it:




 * Thanks, I'm happy with my current implementation, but it's definitely good to see there's more than one way to arrive with the same results. -452 20:02, December 18, 2012 (UTC)


 * Another little thing: You shouldn't append nodes to the document in a loop. It would be much faster to concatenate all those options to a single string and then append the lot of them after the loop. --
 * I agree, but since the current implementation also uses a loop, you can't really fault UltimateSupreme for that. -452 19:43, December 18, 2012 (UTC)


 * I was talking about the loop in your code 452 :)
 * And while am at it: Please, don't use for..in for arrays! :( --
 * Your indents did not indicate you were responding to me. I've now fixed the indents.
 * It's not my code. I did not write the code on Standard_Edit_Summary/code.js. -452 20:02, December 18, 2012 (UTC)
 * I'm not even sure who did originally write it, I'll try to find out and get back to you. -452 20:03, December 18, 2012 (UTC)


 * I'm sorry! I thought that was obvious. All of my comments - including the CSS suggestion - where in references to your rewrite. --
 * Oh ok. Yes, I've made a number of CSS modifications as well, I didn't think to include them, thanks. -452 21:00, December 18, 2012 (UTC)


 * With regards to the origins of this script, I believe it comes from Wookieepedia. It's included in the first revision of their Common.js, way back in 2007 - standard delete reasons and template preloads also exist at this time. It appears that the scripts predate the page, but whether that's a mark of Common.js not being part of MediaWiki back then I don't know.


 * The jQuery version of it was written by Grunny.— UltimateSupreme (Talk)02:59, December 19, 2012 (UTC)


 * Looks like you're both right, the version of wookiepedia was always named "fillEditSummaries", runescape copied "fillEditSummaries" from there, but didn't attribute the source properly, and later renamed it. -452 07:14, December 19, 2012 (UTC)


 * On 2007-10-04, User:Richard1990 pasted a fillEditSummaries script on runescape identical to the one in use on wookiepedia. This script remained in use until 2010-07-16, with fillEditSummaries remaining unchanged and matching wookiepedia's on the same date
 * On 2010-07-17, runescape's script was upgraded by User:Quarenon, and renamed to become the basis for the current version.
 * Wookiepedia's script remained the same until 2011-07-29, it took a different path than runescape's script, but they're both based on the same original script which was on wookiepedia since 2006. (So, Grunny's jQuery filleditsummaries script is not an ancestor of the current script, it is a cousin of the current script, with a shared ancestor which was on wookiepedia before anywhere else currently known. 452 07:58, December 19, 2012 (UTC))
 * Richard1990 plagiarised the script without attribution, Quarenon is responsible for both the "For .. in" loop and the append loop. -452 07:48, December 19, 2012 (UTC)


 * I'm thoroughly confused now. How should we credit this script? And to whom? --
 * Technically, it's within the citing requirements to just link to the copied version. But in theory, the version you're linking should cite the source before them, so that the chain can be followed to the true source, but in practice, since we know this chain is broken... I don't know if it's our responsibility to fix Richard1990's violation.
 * I'd credit Wookiepedia in general ( at least until we find out who wrote it originally - I didn't think of it earlier, but I'll ask on wookiepedia See below), Quarenon from Runescape and Runescape in general, Casualty in general (unless you want to dig and find out who was involved - they were content to credit only their wiki rather than individuals), then there's me and you. -452 17:00, December 20, 2012 (UTC)
 * Looks like Sikon on Wookiepedia wrote it originally, he added it to Monobook.js on 2006-08-20, this forum post happened at the same time, and it appears he wrote it rather than copying it.
 * Additionally, here's some additional proof that User:Richard1990 copied the script from there. -452 17:27, December 20, 2012 (UTC)

Another version
I optimized 452' version a bit and added the CSS for the wide-screen mode of the source editor:


 * If there are no objections, I'll replace the current version with the above today. --