User:Dessamator/The Gentle Art of Script Review

Based on http://sarah.thesharps.us/2014/09/01/the-gentle-art-of-patch-review/.

Phase One: Good or Bad Idea?
This phase only needs a simple yes or no from the reviewer. An example of a bad script might be one that consumes too many system resources.

If the answer to the question below is "no", then there's no point in reviewing further. “Is this contribution a good idea?”

Phase Two: Is this Architecturally Sound?
Review the script to make sure that it "architecturally correct". Some general guidelines:

1. Working code - Review on whether the code does what it is meant to do. 2. Refactoring - Check if some areas should be redone. 3. Improvement - Check if something is actually improved.

Avoid nitpicking and worrying about styling issues in this phase.

Security

 * Validate input - Clearly identify the entry point and make sure it is validated.
 * Escape output - Clearly see if the output is escaped properly. Some Api may do this internally.

Phase Three: Is the Contribution Polished?
Focus on making comments about the style and the general appearance of the code. In particular comment on spelling or grammar mistakes, clearer wording, and any documentation that may be lacking.